You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have NOT tested this on Windows, only Mac. Please nobody merge until I've tested.
Intent
Fixes#414. When building a bundle, follow symlinks. This allows apps to include directories that might live somewhere else for deduplication/centralization reasons.
Type of Change
Bug Fix
New Feature
Breaking Change
Approach
os.walk takes a followlinks argument that defaults to False. I simply set this to True. Note that from googling, os.walk doesn't check for circular references--I'm happy to add that if we think it's important.
Automated Tests
TODO
Directions for Reviewers
Create two sibling directories, one called data and one called shinytest.
shinytest/app.py:
from pathlib import Path
from shiny.express import input, ui
msg_path = Path(__file__).parent / "data/message.txt"
with open(msg_path) as f:
f.read()
data/message.txt:
Hello, world!
Then, from within the shinytest directory, run ln -s ../data data.
Deploy from within the shinytest directory as usual, and see if it crashes on startup or the message correctly appears instead.
Checklist
I have updated CHANGELOG.md to cover notable changes.
I have updated all related GitHub issues to reflect their current state.
I played around with Windows and it's pretty weird.
The good news is symlinks work fine, the command is mklink and Python handles them just fine. I haven't tried with git but it's supposed to work; there's a core.symlinks option that defaults to true.
They're not supported on FAT filesystems but that's probably OK for our purposes.
However, by default, you don't have permissions to call mklink unless you are at an Administrator prompt. That's true even if you have write permissions to the directory where you're trying to create the link--it's the creation of a symlink that's considered a privileged operation. You can put Windows into developer mode (doesn't even require a restart) and then anyone can call mklink.
I played around with Windows and it's pretty weird.
So true 😆
Weird but this is fine to merge, @jcheng5? Even if you're not an admin, you can still follow symlinks, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have NOT tested this on Windows, only Mac. Please nobody merge until I've tested.
Intent
Fixes #414. When building a bundle, follow symlinks. This allows apps to include directories that might live somewhere else for deduplication/centralization reasons.
Type of Change
Approach
os.walktakes afollowlinksargument that defaults toFalse. I simply set this toTrue. Note that from googling,os.walkdoesn't check for circular references--I'm happy to add that if we think it's important.Automated Tests
TODO
Directions for Reviewers
Create two sibling directories, one called
dataand one calledshinytest.shinytest/app.py:
data/message.txt:
Then, from within the shinytest directory, run
ln -s ../data data.Deploy from within the shinytest directory as usual, and see if it crashes on startup or the message correctly appears instead.
Checklist